fix: resolve CI and nightly pipeline failures - #8
Merged
Conversation
gmalbert
commented
Jul 25, 2026
gmalbert
commented
Owner
- Add missing python-dotenv to nightly.yml pip dependencies
- Disable the_hundred, t20_blast, sa20 (broken Cricsheet CSV URLs)
- Fix ruff violations in fetch_data.py (E402, I001, UP017, F841, F541)
- Align test_identity.py with identity.py implementation (method names, signatures)
- Align test_model_validation.py with model_validation.py (ModelMetadata param, return types)
- Add missing python-dotenv to nightly.yml pip dependencies - Disable the_hundred, t20_blast, sa20 (broken Cricsheet CSV URLs) - Fix ruff violations in fetch_data.py (E402, I001, UP017, F841, F541) - Align test_identity.py with identity.py implementation (method names, signatures) - Align test_model_validation.py with model_validation.py (ModelMetadata param, return types) Co-authored-by: CommandCodeBot <[email protected]>
The fix commit changed timezone.utc to datetime.UTC but accidentally removed timezone from the import statement, and UTC is not accessible as a class attribute of datetime.datetime. This caused both the integration test and unit tests to fail with AttributeError. Restore timezone import and use timezone.utc consistently. Co-authored-by: CommandCodeBot <[email protected]>
… test The test_pipeline_writes_match_intelligence_caches test monkeypatches run_pipeline.CACHE_DIR but the PipelineRun class in run_manager.py uses its own separate CACHE_DIR and RUNS_DIR module-level constants. When promote_to_production() copies outputs, they go to the real cache directory instead of the temp directory, causing assertions on tmp_path/rivalries.json to fail. Patch run_manager.CACHE_DIR and RUNS_DIR so pipeline outputs land in the test temp path. Co-authored-by: CommandCodeBot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.