ci(release): install dprint before running version script#4
Merged
Conversation
`bun run version` is `changeset version && dprint fmt packages/*/CHANGELOG.md`. The `dprint fmt` was added after the 3.0.0 release (to keep the regenerated CHANGELOGs from failing the next ci.yml dprint check), but release.yml never installs dprint — only ci.yml does. So the first release to exercise the new version script failed with `dprint: command not found` (exit 127) right after `changeset version` succeeded, before the Version PR could be opened. Add a pinned dprint install (DPRINT_VERSION 0.54.0, matching ci.yml) under ~/.local/bin before the changesets/action step. changeset version itself was already working, and the publish phase (bun run build && changeset publish via npm OIDC) is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4.0.0 Release workflow failed a second time, now at the
dprint fmthalf of the
versionscript:changeset versionitself succeeded — the failure is thatrelease.ymlnever installs dprint (only
ci.ymldoes). Thedprint fmtstep was addedto the
versionscript after the 3.0.0 release, so this is the first releaseto exercise it, and the missing install surfaced now.
This adds a pinned dprint install (
DPRINT_VERSION0.54.0, matchingci.yml) under~/.local/binbefore the changesets/action step.Pre-validated locally:
dprint check .github/workflows/release.ymlandactionlintclean.bun run build(the publish phase's first half) succeeds for all packages,so the subsequent publish round should not regress.
After merge, the Release workflow re-runs with dprint on PATH,
bun run versioncompletes, and the changesets/action opens the "Version packages" PR(protocol 4.0.0, sdk 4.0.0, cli/mcp 3.0.1).