Respect standard HTTP proxy environment variables#1973
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
svarlamov
marked this pull request as ready for review
July 23, 2026 21:10
svarlamov
force-pushed
the
agent/respect-http-proxy
branch
from
July 23, 2026 21:31
6fb4473 to
439031c
Compare
svarlamov
marked this pull request as draft
July 23, 2026 21:31
svarlamov
marked this pull request as ready for review
July 24, 2026 04:37
svarlamov
force-pushed
the
agent/respect-http-proxy
branch
from
July 25, 2026 17:14
439031c to
38b2104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
ureqtransport so git-ai automatically honorsALL_PROXY,HTTPS_PROXY, andHTTP_PROXY, including lowercase variantsNO_PROXY/no_proxybypass rules while preserving native OS TLS trust and existing non-2xx response handlingTestRepocoverage throughgit-ai upgradefor proxy routing, proxy bypass, and responses over ureq's 10 MB convenience-method limitRoot cause
The shared HTTP agent used
ureq2.12 without enabling environment proxy discovery, so git-ai's internal HTTP requests connected directly even when standard proxy variables were configured.Validation
task buildtask fmttask linttask test TEST_FILTER=http_proxytask test TEST_FILTER=tls_native_certstask testsuite (with the locally installeddroidbinary removed fromPATHfor the pre-existing agent-detection isolation test)