Skip to content

Respect standard HTTP proxy environment variables#1973

Merged
svarlamov merged 1 commit into
mainfrom
agent/respect-http-proxy
Jul 25, 2026
Merged

Respect standard HTTP proxy environment variables#1973
svarlamov merged 1 commit into
mainfrom
agent/respect-http-proxy

Conversation

@svarlamov

@svarlamov svarlamov commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary

  • upgrade the shared ureq transport so git-ai automatically honors ALL_PROXY, HTTPS_PROXY, and HTTP_PROXY, including lowercase variants
  • honor NO_PROXY/no_proxy bypass rules while preserving native OS TLS trust and existing non-2xx response handling
  • preserve the previous unlimited response-body behavior for large downloads
  • add end-to-end TestRepo coverage through git-ai upgrade for proxy routing, proxy bypass, and responses over ureq's 10 MB convenience-method limit

Root cause

The shared HTTP agent used ureq 2.12 without enabling environment proxy discovery, so git-ai's internal HTTP requests connected directly even when standard proxy variables were configured.

Validation

  • task build
  • task fmt
  • task lint
  • task test TEST_FILTER=http_proxy
  • task test TEST_FILTER=tls_native_certs
  • full task test suite (with the locally installed droid binary removed from PATH for the pre-existing agent-detection isolation test)

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@socket-security

socket-security Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​ureq@​2.12.1 ⏵ 3.3.080 -1610093100100

View full report

@svarlamov
svarlamov marked this pull request as ready for review July 23, 2026 21:10
devin-ai-integration[bot]

This comment was marked as resolved.

@svarlamov
svarlamov force-pushed the agent/respect-http-proxy branch from 6fb4473 to 439031c Compare July 23, 2026 21:31
@svarlamov
svarlamov marked this pull request as draft July 23, 2026 21:31
@svarlamov
svarlamov marked this pull request as ready for review July 24, 2026 04:37
@svarlamov
svarlamov force-pushed the agent/respect-http-proxy branch from 439031c to 38b2104 Compare July 25, 2026 17:14
@svarlamov
svarlamov merged commit 673c198 into main Jul 25, 2026
39 checks passed
@svarlamov
svarlamov deleted the agent/respect-http-proxy branch July 25, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant