Require global Git config access for daemon startup#1972
Open
svarlamov wants to merge 1 commit into
Open
Conversation
svarlamov
marked this pull request as ready for review
July 23, 2026 20:42
svarlamov
force-pushed
the
feat/daemon-require-gitconfig-access
branch
from
July 25, 2026 23:58
1596459 to
8d2bb67
Compare
svarlamov
force-pushed
the
feat/daemon-require-gitconfig-access
branch
2 times, most recently
from
July 26, 2026 00:48
0170a8f to
d998921
Compare
svarlamov
force-pushed
the
feat/daemon-require-gitconfig-access
branch
from
July 26, 2026 00:58
d998921 to
90dfa50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Require daemon startup to have a readable global Git configuration.
git config --global --listinvocation.Why use Git directly
Git is the source of truth for config path resolution, parsing, and include behavior. A gix preflight added complexity without improving the intended contract: the daemon requires the global config to exist and be readable. The probe runs once at daemon startup, never on the latency-sensitive ingestion path, and has a fixed process bound.
Tests and fixtures
Strict TDD coverage demonstrates that:
daemon startanddaemon run;Isolated
TestRepohomes contain an empty global config by default, matching the installed-product prerequisite; negative tests explicitly remove or replace it. The nasty benchmark fixture likewise creates theGIT_CONFIG_GLOBALfile before starting its isolated daemon.Validated with:
task test TEST_FILTER=git_configtask fmttask linttask test