Decode an unclassified TYPE reply as RedisType.Other#153
Merged
Conversation
RedisType was a closed enum of the six classic types, so typeOf turned any other wire name into a DecodeError, failing the whole call. That breaks TYPE on keys of a preview type the library itself supports (Arrays, vector sets) or any module type (e.g. ReJSON-RL). Add an Other(name) case and make fromWireName total, so an unrecognized type surfaces as RedisType.Other(name) rather than an error.
ghostdogpr
force-pushed
the
fix-type-decode-unknown
branch
from
19ee930 to
f408fa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedisTypewas a closed enum of the six classic types (string, list, set, zset, hash, stream), andtypeOfturned any other wire name into aDecodeError— failing the wholeTYPEcall. That breaksTYPEon keys of:ReJSON-RL).Fix
Add an
Other(name)case toRedisTypeand makefromWireNametotal: an unrecognized wire name now decodes toRedisType.Other(name)instead of erroring.wireNamemapsOther(name)back to its name, so it also round-trips as aSCAN ... TYPEfilter argument.Test
Updated the
KeysSpecTYPE test: it now asserts an unclassified reply (ReJSON-RL) decodes toRedisType.Other("ReJSON-RL")rather than failing. Full core suite (697) passes.