Reduce allocations#14
Merged
Merged
Conversation
ghost1face
commented
Jun 2, 2026
Owner
- Minimize allocations and tighten performance
There was a problem hiding this comment.
Pull request overview
This PR focuses on reducing allocations in the Base62 conversion path and adding a BenchmarkDotNet harness to measure the impact of those changes within the solution.
Changes:
- Optimize
Base62Converterby removingList<>/StringBuilderusage in hot paths (array-based base conversion and char-buffer string construction). - Add a new
Base62.Benchmarkproject (plus a helper script) to benchmark current code vs. the latest NuGet package version. - Update solution configuration/platform entries and ignore BenchmarkDotNet artifacts.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| benchmark.sh | Adds a simple script to run the benchmark project in Release. |
| Base62/Base62Converter.cs | Reworks encoding/decoding and base conversion to reduce allocations and improve performance. |
| Base62.sln | Adds the benchmark project and x86/x64 configurations. |
| Base62.Benchmark/Program.cs | Runs benchmarks and fetches latest NuGet package versions via dotnet package search. |
| Base62.Benchmark/BenchmarkConfig.cs | Defines BenchmarkDotNet jobs for current project + selected NuGet versions. |
| Base62.Benchmark/Base62Benchmark.cs | Adds benchmark cases for string/byte encode/decode scenarios (incl. leading zeros). |
| Base62.Benchmark/Base62.Benchmark.csproj | New benchmark project targeting net10.0, with conditional project vs. package reference. |
| Base62.Benchmark/Nuget/NugetPackage.cs | DTO for NuGet search JSON payload. |
| Base62.Benchmark/Nuget/NugetSourceResult.cs | DTO for NuGet search JSON payload. |
| Base62.Benchmark/Nuget/NugetSearchResultRoot.cs | DTO root for NuGet search JSON payload. |
| .gitignore | Ignores BenchmarkDotNet.Artifacts/. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.