spec: fix dflash target tokenizer mismatch during conversion#25733
Conversation
|
@ggerganov Now it should be fixed. The Gemma4 DFlash also works well. |
|
Thanks. There is Python type check error that should be fixed. On a similar note, I found that the following Eagle3 model does not convert: Command: python3 ./llama.cpp/convert_hf_to_gguf.py ./model-temp-gpt_oss_120b-EAGLE3 \
--outtype bf16 --target-model ./model-temp-gpt_oss_120b-PRIMARY \
--outfile ./upload-gpt_oss_120b/eagle3-gpt-oss-120b-BF16.gguf \
--model-name gpt-oss-120bError: Details |
This EAGLE3 checkpoint appears to be relatively new, and its architecture or configuration may have changed. Supporting this new checkpoint would likely require a separate PR to add explicit support for it. |
@ggerganov I created another PR to add support for this eagle3-v3 model: #25794 |
Overview
Fix DFlash conversion issue. See #22105 (comment)
Root cause:
DFlashDraftModelalways used the Qwen vocab path, so target models needing different tokenizer handling (e.g. Gemma-4, which has notokenizer.model) failed with"BPE pre-tokenizer was not recognized".Solution: set
set_vocabto read the target's architecture from itsconfig.jsonand dispatches to that architecture's ownset_vocab.Tested with Gemma4 DFlash models, works as expected.
Requirements