common : skip empty implicit default preset#25643
Open
hogeheer499-commits wants to merge 1 commit into
Open
Conversation
The INI parser creates an implicit default section for top-level metadata. After reserved keys such as `version` are skipped, that section can have no model options but was still added and exposed in router mode. Skip only the empty implicit default while preserving real default presets, named presets, and the global `[*]` settings. Signed-off-by: JS van Dijk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The INI parser creates an implicit default section for top-level metadata. After reserved keys such as
versionare skipped, that section can have no model options but was still added and exposed in router mode.Skip only the empty implicit default while preserving real default presets, named presets, and the global
[*]settings.Additional information
Fixes #22364
Verification performed:
llama-server.model=...is still preserved.[*]settings are still applied without being exposed as a model.git diff --checkpasses.Requirements
COMMON_PRESET_DEFAULT_NAMEconstant instead of the literal"default", ran the build and three router-mode tests, and helped verify the diff. I reviewed the change, understand how it works, and take responsibility for it.