opencl: handle OOB write in noshuffle GEMV kernels (odd ne01)#25640
Draft
wanghqc wants to merge 1 commit into
Draft
opencl: handle OOB write in noshuffle GEMV kernels (odd ne01)#25640wanghqc wants to merge 1 commit into
wanghqc wants to merge 1 commit into
Conversation
github-actions
Bot
added
ggml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to fix a critical out-of-bounds write bug: in 9 of 11 noshuffle decode GEMV kernels — the kernels pad their x-grid (to 128 for the 2-row writers, to the wave size for the 1-row writers) and then vstore2/dst[gid] with no bounds check, so on an ne01 that is not a multiple of the tiling the tail work-items write past the end of dst. Some models fail to generate coherent results due to the bug.
Additional information
None
Requirements