opencl: fix a dp4a bug for devices where cl_khr_integer_dot_product is unavailable#25639
Open
wanghqc wants to merge 2 commits into
Open
opencl: fix a dp4a bug for devices where cl_khr_integer_dot_product is unavailable#25639wanghqc wants to merge 2 commits into
wanghqc wants to merge 2 commits into
Conversation
github-actions
Bot
added
ggml
max-krasnyansky
approved these changes
Jul 13, 2026
lhez
force-pushed
the
hq/dp4a-qcom-dot-portability
branch
from
ebf96b1 to
9c6df16
Compare
lhez
approved these changes
Jul 14, 2026
Contributor
|
@ggml-org/maintainers @max-krasnyansky Can I please get another approval/reapproval? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to fix the crash on devices where the OpenCL KHR extension cl_khr_integer_dot_product is unavailable. Building of the DP4A functions will be skipped.
Additional information
Tested with a fleet of Adreno GPUs, including A642, A740, A840, A850, and X1, and X2.
Requirements
None.