Skip to content

ui: fix thinking menu never appearing in single-model mode#25637

Open
ServeurpersoCom wants to merge 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-thinking-menu-single-model
Open

ui: fix thinking menu never appearing in single-model mode#25637
ServeurpersoCom wants to merge 1 commit into
ggml-org:masterfrom
ServeurpersoCom:ui/fix-thinking-menu-single-model

Conversation

@ServeurpersoCom

@ServeurpersoCom ServeurpersoCom commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Overview

Fixes the thinking menu never showing up when llama-server runs a single model (no router mode).

Previously, the reasoning controls only appeared in router mode: with a single loaded model, the WebUI never detected thinking support from the chat template, so reasoning models like Qwen3 or DeepSeek R1 had no way to toggle thinking from the UI.

The model's chat template is now read from the server's /props directly in single-model mode, so the thinking menu appears whenever the loaded model supports it. No change in router mode.

Additional information

Sans titre

Fixes #25580

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: YES Fable 5 / Self-hosted MCP sandbox servers with shared GPUs

In MODEL mode, modelPropsCache is never populated: fetchModelProps
call sites are gated on router-only state (isRouterMode checks,
routerModels always empty), so supportsThinking always reads an
empty chat template once a model is auto-selected.

Read serverStore.props.chat_template directly in non-router mode,
since the global /props already describes the single loaded model.
@ServeurpersoCom ServeurpersoCom requested a review from a team as a code owner July 13, 2026 19:44
@ServeurpersoCom

Copy link
Copy Markdown
Contributor Author

It's a targeted fix, but the broader idea is that we could eventually drop single-model mode entirely and treat it as the N=1 case of router mode, reducing the amount of code paths to maintain. From the UI standpoint at least; whether the backend needs anything beyond very minor adjustments remains to be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eval bug: Unable to enable thinking llama-cpp web ui

2 participants