Skip to content

tests: export-graph-ops: exit gracefully when called w/o arguments#25619

Merged
ggerganov merged 1 commit into
ggml-org:masterfrom
ckastner:tests-exit-gracefully
Jul 14, 2026
Merged

tests: export-graph-ops: exit gracefully when called w/o arguments#25619
ggerganov merged 1 commit into
ggml-org:masterfrom
ckastner:tests-exit-gracefully

Conversation

@ckastner

@ckastner ckastner commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Overview

Fixes a segfault when test-export-graph-ops is called without any arguments.

$ build/bin/test-export-graph-ops
Segmentation fault         build/bin/test-export-graph-ops

Additional information

The segfault also races with the logging output, sometimes the cause (missing parameter) is not logged. Discovered after the initial report.

Requirements

@github-actions github-actions Bot added the testing Everything test related label Jul 13, 2026
Fixes a segfault when `test-export-graph-ops` is called without any
arguments.
@ckastner ckastner force-pushed the tests-exit-gracefully branch from d480dfd to 03fba0f Compare July 14, 2026 09:54
@ckastner

Copy link
Copy Markdown
Collaborator Author

Coincidentally, the segfault also contained a log race similar to #25504 just discussed. So the cause of the error was not always shown. Sample segfault-output.txt from a container, looping over 20x invocations.

By returning cleanly, the output appears deterministic again, at least on my end, and the cause for invocation failure is shown.

@ckastner ckastner marked this pull request as ready for review July 14, 2026 10:01
@ckastner ckastner requested a review from ggerganov as a code owner July 14, 2026 10:01
@ggerganov ggerganov merged commit 657e011 into ggml-org:master Jul 14, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Everything test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants