tests: export-graph-ops: exit gracefully when called w/o arguments#25619
Merged
Conversation
Fixes a segfault when `test-export-graph-ops` is called without any arguments.
d480dfd to
03fba0f
Compare
Collaborator
Author
|
Coincidentally, the segfault also contained a log race similar to #25504 just discussed. So the cause of the error was not always shown. Sample segfault-output.txt from a container, looping over 20x invocations. By returning cleanly, the output appears deterministic again, at least on my end, and the cause for invocation failure is shown. |
ggerganov
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a segfault when
test-export-graph-opsis called without any arguments.Additional information
The segfault also races with the logging output, sometimes the cause (missing parameter) is not logged. Discovered after the initial report.
Requirements