security: restrict server CORS to loopback origins#25606
Open
macncrash wants to merge 1 commit into
Open
Conversation
Reflecting the request Origin header with credentials allowed any browser origin to make cross-origin requests against a local llama-server API that often has no API key configured. Restrict Access-Control-Allow-Origin to localhost/127.0.0.1 origins and reject other Origins with 403. Narrow Allow-Headers for preflight. Reporter: macncrash
|
Hi @macncrash, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
bulat3677
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server previously set
Access-Control-Allow-Originto the request Origin (any site) while advertising credentials. Combined with an often-unauthenticated local API, this enables browser CSRF-style abuse of llama-server from malicious web pages.Change
Test plan
Disclosure
Per SECURITY.md (private program currently disabled; public PRs preferred).
Reporter: macncrash · AI-assisted analysis; human-verified.