Skip to content

fix: skip invalid Neo4j embeddings in similarity search#1554

Open
he-yufeng wants to merge 1 commit into
getzep:mainfrom
he-yufeng:fix/neo4j-similarity-invalid-embeddings
Open

fix: skip invalid Neo4j embeddings in similarity search#1554
he-yufeng wants to merge 1 commit into
getzep:mainfrom
he-yufeng:fix/neo4j-similarity-invalid-embeddings

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

Tests

  • python -m py_compile graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py
  • python -m ruff check graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py
  • git diff --check
  • pytest target: 11 passed, 1 warning

Note: the pytest command had to remove unrelated editable checkout paths from sys.path because this Windows environment has other local repos exposing a top-level tests package.

@zep-cla-assistant

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. For privacy information, see our Privacy Notice. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

or

I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: [email protected]

Signature is valid for 6 months.


This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot.

@he-yufeng

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected] .

@he-yufeng he-yufeng force-pushed the fix/neo4j-similarity-invalid-embeddings branch from 4c3e314 to 5c4fa8c Compare June 11, 2026 23:31
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this onto the current main branch and kept both the upstream FalkorDB group-id regression tests and this PR's Neo4j invalid-embedding guards.\n\nLocal validation:\n- python -m py_compile graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- python -m ruff check graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- python -m ruff format --check graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- targeted pytest for the Neo4j/FalkorDB search-security cases: 6 passed, 7 deselected\n- git diff --check origin/main..HEAD\n\nThe first direct pytest attempt in my global Windows environment picked up another installed package named tests; rerunning with the repo's tests package isolated passed.

@he-yufeng

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

@he-yufeng

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA on behalf of myself, e-mail: [email protected]

@he-yufeng

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] edge_similarity_search crashes on edges with null/invalid fact_embedding

1 participant