fix: skip invalid Neo4j embeddings in similarity search#1554
Conversation
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected] or I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: [email protected] Signature is valid for 6 months. This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot. |
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected] . |
4c3e314 to
5c4fa8c
Compare
|
Rebased this onto the current main branch and kept both the upstream FalkorDB group-id regression tests and this PR's Neo4j invalid-embedding guards.\n\nLocal validation:\n- python -m py_compile graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- python -m ruff check graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- python -m ruff format --check graphiti_core\driver\neo4j\operations\search_ops.py tests\utils\search\test_search_security.py\n- targeted pytest for the Neo4j/FalkorDB search-security cases: 6 passed, 7 deselected\n- git diff --check origin/main..HEAD\n\nThe first direct pytest attempt in my global Windows environment picked up another installed package named tests; rerunning with the repo's tests package isolated passed. |
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected] |
|
I have read the CLA Document and I hereby sign the CLA on behalf of myself, e-mail: [email protected] |
|
I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected] |
Summary
edge_similarity_searchcrashes on edges with null/invalidfact_embedding#1328Tests
Note: the pytest command had to remove unrelated editable checkout paths from sys.path because this Windows environment has other local repos exposing a top-level tests package.