Skip to content

fix(mcp): preserve FalkorDB URI username#1530

Open
he-yufeng wants to merge 1 commit into
getzep:mainfrom
he-yufeng:fix/falkor-uri-username
Open

fix(mcp): preserve FalkorDB URI username#1530
he-yufeng wants to merge 1 commit into
getzep:mainfrom
he-yufeng:fix/falkor-uri-username

Conversation

@he-yufeng

Copy link
Copy Markdown
Contributor

Summary

Fixes #1522.

FalkorDB Cloud URIs can include a username, for example redis://falkordb:<password>@host:port. The MCP server factory parsed host and port from FALKORDB_URI, but dropped parsed.username; GraphitiService then built FalkorDriver without a username, so the client authenticated as the implicit Redis default user.

This keeps the existing URI/password behavior and adds username propagation:

  • parse the username from FALKORDB_URI
  • allow FALKORDB_USERNAME / config username to override it
  • pass the username into FalkorDriver
  • add MCP server config tests for URI username preservation and env override

To verify

  • $env:PYTHONPATH='..;src'; python -m pytest tests\test_falkordb_config.py -q -> 2 passed
  • python -m py_compile src\config\schema.py src\services\factories.py src\graphiti_mcp_server.py tests\test_falkordb_config.py
  • python -m ruff check src\config\schema.py src\services\factories.py src\graphiti_mcp_server.py tests\test_falkordb_config.py
  • python -m ruff format --check src\config\schema.py src\services\factories.py src\graphiti_mcp_server.py tests\test_falkordb_config.py
  • git diff --check

@zep-cla-assistant

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. For privacy information, see our Privacy Notice. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

or

I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: [email protected]

Signature is valid for 6 months.


This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot.

@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto the latest upstream main and force-pushed the cleaned head.

Validated locally:

  • python -m py_compile mcp_server/src/config/schema.py mcp_server/src/graphiti_mcp_server.py mcp_server/src/services/factories.py mcp_server/tests/test_falkordb_config.py
  • PYTHONPATH=<repo-root>;mcp_server/src uv run pytest -q mcp_server/tests/test_falkordb_config.py (2 passed)
  • git diff --check origin/main..HEAD

The remaining GitHub failures appear to be repository automation credentials (CLAAssistant, review, triage) rather than a test failure from this patch.

@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto current getzep:main and reran the focused validation.

Validation:

python -m py_compile mcp_server\src\config\schema.py mcp_server\src\graphiti_mcp_server.py mcp_server\src\services\factories.py mcp_server\tests\test_falkordb_config.py
PYTHONPATH=<repo-root>;mcp_server/src uv run pytest -q mcp_server\tests\test_falkordb_config.py
# 2 passed
git diff --check origin/main..HEAD

Remaining non-code item: the CLA Assistant still requires the contributor agreement comment from my account.

@he-yufeng he-yufeng force-pushed the fix/falkor-uri-username branch from d3ab134 to 7f7099b Compare June 12, 2026 01:31
@he-yufeng

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto the current getzep:main and reran the focused validation.

Validation:

python -m py_compile mcp_server\src\config\schema.py mcp_server\src\graphiti_mcp_server.py mcp_server\src\services\factories.py mcp_server\tests\test_falkordb_config.py
PYTHONPATH=<repo-root>;mcp_server/src uv run --frozen pytest -q mcp_server\tests\test_falkordb_config.py
# 2 passed
git diff --check upstream/main..HEAD

Current head: 7f7099b.

I have read the CLA Document and I hereby sign the CLA on behalf of myself, e-mail: [email protected]

@he-yufeng

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FalkorDB driver factory drops URI username, breaks FalkorDB Cloud auth

1 participant