Track scheduled driver index build tasks#1519
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ritwij Aryan Parmar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1513 by keeping references to the constructor-scheduled index build tasks in the Neo4j and FalkorDB drivers, then cancelling/awaiting them during driver close before closing the underlying database client.
This prevents the fire-and-forget
build_indices_and_constraints()task from being abandoned when a function-scoped event loop or short-lived application shuts down.Changes
Neo4jDriverandFalkorDriverclose(), retrieve completed task exceptions or cancel and await pending tasksTests
/tmp/graphiti/.venv/bin/python -m ruff check graphiti_core/driver/neo4j_driver.py graphiti_core/driver/falkordb_driver.py tests/driver/test_neo4j_driver.py tests/driver/test_falkordb_driver.py/tmp/graphiti/.venv/bin/python -m pytest tests/driver/test_neo4j_driver.py tests/driver/test_falkordb_driver.pyResult: 25 passed, 1 skipped.
I have read and agree to the Zep CLA.