Skip to content

fix(mcp): preserve default temperature for non-openai llms#1464

Closed
fengfeng-zi wants to merge 1 commit into
getzep:mainfrom
fengfeng-zi:fix/mcp-non-openai-default-temperature-1103
Closed

fix(mcp): preserve default temperature for non-openai llms#1464
fengfeng-zi wants to merge 1 commit into
getzep:mainfrom
fengfeng-zi:fix/mcp-non-openai-default-temperature-1103

Conversation

@fengfeng-zi

Copy link
Copy Markdown
Contributor

Summary

  • stop overriding Graphiti core's default temperature when MCP config leaves temperature unset for Anthropic, Gemini, and Groq providers
  • keep explicit temperature overrides intact
  • add focused factory regression tests for unset and explicit temperature behavior

Testing

  • .venv\Scripts\python.exe -m pytest mcp_server\tests\test_factories.py -q

Closes #1103

@danielchalef

Copy link
Copy Markdown
Member

Thanks for this — you correctly diagnosed that the MCP factory sends temperature=None to the non-OpenAI clients (Anthropic/Gemini/Groq), which pass it to their APIs verbatim and 400 (#1103). I've reimplemented the fix directly on main as #1570 (this branch was CI-red and behind), using the same omit-when-unset approach with a parametrized test across all three providers. Closing as superseded by #1570 — credit to you for the fix.

@zep-cla-assistant zep-cla-assistant Bot locked and limited conversation to collaborators Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] MCP Server: Anthropic provider fails with 400 error when temperature not explicitly set

2 participants