onedrive-gui: Update to v1.3.0#8525
Conversation
**Summary** This PR resolves software update request getsolus#8199. Bugfixes: - Fix non-working sync after big delete - Fix missing resync dialog when full-resync is enabled in the config - Fix detection of already running onedrive process Enhancements: - Option for autostart on login - File transfer UI shows timestamp in relative format - System tray icon shows synchronization status Full release notes: - [1.3.0](https://github.com/bpozdena/OneDriveGUI/releases/tag/v1.3.0) Signed-off-by: Maik Wöhl <[email protected]>
|
I'm not a big fan of going from multiple smaller, targeted patches to one big megapatch. Keeping changes to smaller patches that only do a single thing, one, is a lot easier to review, and two, is more maintainable because instead of having to rebase a single huge patch, you might only have to do a couple of small ones. |
EbonJaeger
left a comment
EbonJaeger
left a comment
There was a problem hiding this comment.
This should also have an AppStream metainfo file, since it is a desktop application that ships a .desktop file. If the upstream project doesn't have one, we'll have to create one; there are a bunch of packages in the repository that do this.
| install -D -m00644 src/onedrive_gui/resources/OneDriveGUI.desktop $installdir/usr/share/applications/OneDriveGUI.desktop | ||
| install -D -m00644 src/onedrive_gui/resources/images/icons8-clouds-48.png $installdir/usr/share/icons/onedrive-gui.png | ||
| install -D -m00644 src/onedrive_gui/resources/images/OneDriveGUI.png $installdir/usr/share/icons/OneDriveGUI.png | ||
| install -D -m00644 src/onedrive_gui/resources/images/OneDriveGUI.ico $installdir/usr/share/icons/OneDriveGUI.ico |
There was a problem hiding this comment.
Do we need an .ico file on Linux?
| %python3_install | ||
| install -D -m00644 src/onedrive_gui/resources/OneDriveGUI.desktop $installdir/usr/share/applications/OneDriveGUI.desktop | ||
| install -D -m00644 src/onedrive_gui/resources/images/icons8-clouds-48.png $installdir/usr/share/icons/onedrive-gui.png | ||
| install -D -m00644 src/onedrive_gui/resources/images/OneDriveGUI.png $installdir/usr/share/icons/OneDriveGUI.png |
There was a problem hiding this comment.
This is in the wrong place. It should be in ${installdir}/usr/share/icons/hicolor/<size>/apps/, where size is whatever size the icon is.
2 participants
Summary
Resolves #8199.
Bugfixes:
Enhancements:
Full release notes:
Test Plan
Checklist