feat(spans): Remove references to old -if syntax

[wmak]

• This removes the old if syntax from the prebuilt dashboards
• Depends on feat(spans): Add new conditional if syntax #120684
• https://linear.app/getsentry/issue/BROWSE-559/migrate-any-existing-multi-parameter-style-if-combinators-to-the

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 459a17f. Configure here.}

[cursor]

Malformed avg_if equation syntax

High Severity

The new avg_if expressions place backticks and commas incorrectly, producing a filter like `span.op:queue.process,`span.duration, instead of `span.op:queue.process`,span.duration. The same broken form appears in the Average Processing Time widget and Consumer Transactions table, while queues.ts and laravelOverview.ts use the correct syntax. Those queue detail widgets will fail to query.

Additional Locations (2)

• static/app/views/dashboards/utils/prebuiltConfigs/queues/queueDetails.ts#L179-L180
• static/app/views/dashboards/utils/prebuiltConfigs/queues/queueDetails.ts#L186-L187

 

^{Reviewed by Cursor Bugbot for commit 459a17f. Configure here.}

[DominikB2014]

Looks valid, the backtick is after the coma

[sentry]

Bug: The avg_if function calls in queueDetails.ts have a misplaced backtick and an extra trailing comma, creating a malformed query string for the dashboard widgets.
_{Severity: HIGH}

Suggested Fix

Correct the avg_if function calls in queueDetails.ts. Move the closing backtick to be before the comma separating the arguments, and remove the trailing comma after the SpanFields.SPAN_DURATION variable. The correct format should be `equation|avg_if(\`${SpanFields.SPAN_OP}:queue.process\`,${SpanFields.SPAN_DURATION})`. Apply this fix to all identified occurrences.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: static/app/views/dashboards/utils/prebuiltConfigs/queues/queueDetails.ts#L43

Potential issue: In `queueDetails.ts`, several `avg_if` function calls are constructed
with incorrect syntax. Specifically, the backtick closing the filter condition is placed
after the comma, and an extra trailing comma is added after the duration field. This
results in a malformed query string like ``
`equation|avg_if(\`span.op:queue.process,\`span.duration,)` `` instead of the correct ``
`equation|avg_if(\`span.op:queue.process\`,span.duration)` ``. This malformed query will
be sent to the backend, likely causing the "Average Processing Time" and "Consumer
Transactions" dashboard widgets to either fail with an error or display incorrect data.

Also affects:

• static/app/views/dashboards/utils/prebuiltConfigs/queues/queueDetails.ts:180~180
• static/app/views/dashboards/utils/prebuiltConfigs/queues/queueDetails.ts:187~187

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[DominikB2014]

Asides from the small cursor comment, lgtm!

[getsantry]

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

---

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀