fix(replay): Forward Session Replay network detail options to native SDKs#6373
Draft
antonis wants to merge 5 commits into
Draft
fix(replay): Forward Session Replay network detail options to native SDKs#6373antonis wants to merge 5 commits into
antonis wants to merge 5 commits into
Conversation
…SDKs Network detail capture for Mobile Session Replay is implemented in the JS layer (xhrUtils enriches breadcrumbs), but the rrweb options event that tells the Sentry frontend to render request/response bodies and headers is emitted by the native SDKs from their SentryReplayOptions. RN never forwarded the network detail config to native, so SentryReplayOptions.networkDetailAllowUrls stayed empty, networkDetailHasUrls was false, and the frontend never rendered the captured details. Forward networkDetailAllowUrls, networkDetailDenyUrls, networkCaptureBodies, networkRequestHeaders and networkResponseHeaders from mobileReplayOptions into the native SentryReplayOptions on both platforms. RegExp allow/deny patterns can't cross the native bridge, so they are forwarded as their string source; JS-side matching in xhrUtils keeps using the original RegExp values. Co-Authored-By: Claude Opus 4.8 <[email protected]>
Co-Authored-By: Claude Opus 4.8 <[email protected]>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Author
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 47cb22d. Configure here.
Allow-list the Spaceflight News API host and enable networkCaptureBodies so the sample exercises request/response detail rendering in the Replay network tab via the existing News screen. Co-Authored-By: Claude Opus 4.8 <[email protected]>
📲 Install BuildsAndroid
|
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a858ac3+dirty | 3836.62 ms | 1222.56 ms | -2614.06 ms |
| 038a6d7+dirty | 3849.69 ms | 1228.40 ms | -2621.28 ms |
| c2e182c+dirty | 3848.40 ms | 1211.79 ms | -2636.61 ms |
| 5748023+dirty | 3840.49 ms | 1227.43 ms | -2613.05 ms |
| b0d3373+dirty | 3831.75 ms | 1227.29 ms | -2604.46 ms |
| 7887847+dirty | 3849.83 ms | 1227.35 ms | -2622.48 ms |
| 6177334+dirty | 3834.85 ms | 1217.58 ms | -2617.28 ms |
| 21a1e70+dirty | 3834.15 ms | 1218.43 ms | -2615.73 ms |
| 774257e+dirty | 3846.90 ms | 1215.02 ms | -2631.88 ms |
| 15d4514+dirty | 3840.17 ms | 1225.79 ms | -2614.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a858ac3+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 038a6d7+dirty | 5.15 MiB | 6.70 MiB | 1.55 MiB |
| c2e182c+dirty | 4.98 MiB | 6.50 MiB | 1.52 MiB |
| 5748023+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| b0d3373+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 7887847+dirty | 4.98 MiB | 6.46 MiB | 1.48 MiB |
| 6177334+dirty | 5.15 MiB | 6.68 MiB | 1.53 MiB |
| 21a1e70+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| 774257e+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| 15d4514+dirty | 5.15 MiB | 6.70 MiB | 1.55 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a858ac3+dirty | 3850.72 ms | 1226.35 ms | -2624.37 ms |
| a50b33d+dirty | 1207.11 ms | 1212.10 ms | 5.00 ms |
| c2e182c+dirty | 3841.76 ms | 1220.76 ms | -2621.01 ms |
| 7436d0f+dirty | 3861.51 ms | 1231.07 ms | -2630.44 ms |
| 5a21b51+dirty | 3837.87 ms | 1223.47 ms | -2614.40 ms |
| 09a902f+dirty | 3847.65 ms | 1221.31 ms | -2626.34 ms |
| ad66da3+dirty | 3855.02 ms | 1213.43 ms | -2641.59 ms |
| eb93136+dirty | 3846.51 ms | 1226.13 ms | -2620.39 ms |
| d2eadf8+dirty | 3841.53 ms | 1216.15 ms | -2625.39 ms |
| 1e5d96d+dirty | 3845.93 ms | 1222.51 ms | -2623.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a858ac3+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| a50b33d+dirty | 3.38 MiB | 4.73 MiB | 1.35 MiB |
| c2e182c+dirty | 4.98 MiB | 6.51 MiB | 1.53 MiB |
| 7436d0f+dirty | 5.15 MiB | 6.70 MiB | 1.54 MiB |
| 5a21b51+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 09a902f+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
| ad66da3+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| eb93136+dirty | 5.15 MiB | 6.69 MiB | 1.53 MiB |
| d2eadf8+dirty | 5.15 MiB | 6.67 MiB | 1.51 MiB |
| 1e5d96d+dirty | 4.98 MiB | 6.46 MiB | 1.49 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5569641+dirty | 465.92 ms | 532.22 ms | 66.30 ms |
| 3b6e9f9+dirty | 442.39 ms | 486.44 ms | 44.05 ms |
| b04af96+dirty | 430.33 ms | 485.98 ms | 55.65 ms |
| 68ae91b+dirty | 515.04 ms | 578.08 ms | 63.04 ms |
| f3215d3+dirty | 396.53 ms | 436.66 ms | 40.13 ms |
| df5d108+dirty | 434.82 ms | 447.39 ms | 12.57 ms |
| 6176a94+dirty | 403.58 ms | 446.73 ms | 43.15 ms |
| 71abba0+dirty | 411.04 ms | 453.67 ms | 42.63 ms |
| 822d35b+dirty | 472.69 ms | 561.24 ms | 88.56 ms |
| 5a23c47+dirty | 406.83 ms | 451.47 ms | 44.64 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5569641+dirty | 48.30 MiB | 53.48 MiB | 5.18 MiB |
| 3b6e9f9+dirty | 48.30 MiB | 53.54 MiB | 5.23 MiB |
| b04af96+dirty | 49.74 MiB | 55.00 MiB | 5.26 MiB |
| 68ae91b+dirty | 49.74 MiB | 54.79 MiB | 5.05 MiB |
| f3215d3+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| df5d108+dirty | 43.94 MiB | 48.94 MiB | 5.00 MiB |
| 6176a94+dirty | 48.30 MiB | 53.54 MiB | 5.24 MiB |
| 71abba0+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
| 822d35b+dirty | 49.74 MiB | 54.84 MiB | 5.10 MiB |
| 5a23c47+dirty | 49.74 MiB | 54.82 MiB | 5.07 MiB |
…twork-detail-options
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a3265b6+dirty | 406.86 ms | 449.84 ms | 42.98 ms |
| 20fbd51+dirty | 487.89 ms | 535.60 ms | 47.71 ms |
| 5ee78d6+dirty | 551.80 ms | 568.27 ms | 16.47 ms |
| a50b33d+dirty | 500.81 ms | 532.11 ms | 31.30 ms |
| 7a89652+dirty | 537.76 ms | 567.84 ms | 30.08 ms |
| 09a902f+dirty | 427.38 ms | 473.80 ms | 46.42 ms |
| 68ae91b+dirty | 416.44 ms | 477.56 ms | 61.12 ms |
| 4b87b12+dirty | 421.82 ms | 413.60 ms | -8.22 ms |
| 23598c3+dirty | 414.12 ms | 426.24 ms | 12.12 ms |
| 71abba0+dirty | 496.54 ms | 525.16 ms | 28.63 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a3265b6+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| 20fbd51+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 5ee78d6+dirty | 48.30 MiB | 53.58 MiB | 5.28 MiB |
| a50b33d+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 7a89652+dirty | 48.30 MiB | 53.60 MiB | 5.30 MiB |
| 09a902f+dirty | 49.74 MiB | 54.81 MiB | 5.07 MiB |
| 68ae91b+dirty | 49.74 MiB | 54.79 MiB | 5.05 MiB |
| 4b87b12+dirty | 43.75 MiB | 48.14 MiB | 4.39 MiB |
| 23598c3+dirty | 43.75 MiB | 48.16 MiB | 4.41 MiB |
| 71abba0+dirty | 48.30 MiB | 53.49 MiB | 5.19 MiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Enhances the network detail capture for Mobile Session Replay (added in #6288) by forwarding the network-detail options into the native
SentryReplayOptionson both platforms:RNSentryReplay.mm): adds the keys to thesessionReplaydict; Cocoa'sSentryReplayOptions(dictionary:)already parses them.RNSentryStart.getReplayOptions): reads the keys and calls the existingsetNetworkDetail*setters.client.ts/mobilereplay.ts):RegExpallow/deny patterns can't cross the native bridge (they serialize to{}), so they are forwarded as their stringsource. JS-side matching inxhrUtilskeeps using the originalRegExpvalues in order to drive the frontend render signal.💡 Motivation and Context
Follow-up to #6288
💚 How did you test it?
CI checks and tests, Manual
📝 Checklist
sendDefaultPiiis enablednetworkDetailAllowUrls(empty by default); auth-like headers are always stripped in the JS layer.🔮 Next steps