Add loader on OAuth2 consent page submit#1452
Draft
gearnode wants to merge 2 commits into
Draft
Conversation
Track a pending allow/deny action with Button loading spinners so users cannot double-submit while the approveConsent mutation runs or while the browser waits on the OAuth callback redirect. Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Bryan FRIMIN <[email protected]>
After allow or deny succeeds, replace the consent form with a full-page redirect message naming the application and a spinner while the browser navigates to the OAuth callback URL. Signed-off-by: Cursor Agent <[email protected]> Co-authored-by: Bryan FRIMIN <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the OAuth2 consent page, clicking Allow or Deny now shows a loading spinner on the clicked button while the mutation runs. After a successful response, the form is replaced with a full-page redirect screen that names the application and shows a spinner while the browser navigates to the OAuth callback URL. This prevents double submits and gives clearer feedback during slow redirects.
Changes
pendingActionstate while the mutation is in flight; disable both buttons and show a spinner on the active oneredirectURL, show a full-page state:useEffectonce the redirect screen is shownTest plan
/auth/consent?consent_id=…)Linear Issue: ENG-579
Summary by cubic
Adds a loading state and a post-submit redirect screen to the OAuth2 consent page. Meets Linear ENG-579 by preventing double submits and showing clear feedback during the OAuth redirect.
App: console
+51-9pendingActionto block repeat clicks and disable both buttonsloadingspinners; keep until redirectwindow.locationinuseEffectisInFlightWritten for commit f9f1ce5. Summary will update on new commits.