Fetch Microsoft MFA statuses#1320
Draft
gearnode wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Cursor Agent <[email protected]>
Signed-off-by: Cursor Agent <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
make go-fmtgo test ./pkg/accessreview/drivers ./pkg/connector/providergit diff --checkNote:
golangci-lintis not installed in the local cloud container, so the exact CI lint command could not be rerun locally.Linear Issue: ENG-467
Summary by cubic
Show MFA status for Microsoft 365 users in access reviews by fetching Graph user registration details and mapping them to
coredata.MFAStatus. Adds thehttps://graph.microsoft.com/AuditLog.Read.Allscope and addresses ENG-467 (Microsoft connector does not show MFA).Service
+99-1reports/authenticationMethods/userRegistrationDetailswith pagination.isMfaRegisteredtoEnabled/Disabled/Unknown.https://graph.microsoft.com/AuditLog.Read.Allin Microsoft 365 connector registration.Tests
+98-0Written for commit d9d33b6. Summary will update on new commits.