Add direct workspace grouping toggle for quick switching between Projects and Statuses by panrafal · Pull Request #4359 · getpaseo/paseo

panrafal · 2026-09-05T14:05:28Z

Linked issue

None

Type of change

Reasoning

Switching workspace grouping currently requires navigating through Display preferences. This adds a direct Workspaces-header control while retaining the descriptive menu choice.

Search remains available. The grouping icon and tooltip represent the currently selected mode, while the control cycles to the other mode when activated.

Goals

Add a direct project/status grouping toggle to the Workspaces header.
Keep Search and Display preferences available.
Display the current grouping through the toggle icon and tooltip.
Identify the control as a grouping switcher for screen readers.
Retain the descriptive Grouping page in Display preferences.
Add a Cmd/Ctrl+; grouping shortcut to Projects & Workspaces.
Keep grouping persistence and Command Center behavior unchanged.
Support keyboard layouts where ; requires Shift.
Ignore the shortcut in editable fields and terminals.

Non-goals

Change project or status grouping behavior.
Change workspace ordering or filtering.
Remove grouping from the Command Center.
Add shortcut customization.
Change other Display preferences.

QA

Focused unit tests

$ npx vitest run packages/app/src/keyboard/keyboard-shortcuts.test.ts packages/app/src/keyboard/route-shortcut.test.ts packages/app/src/stores/sidebar-view-store.test.ts packages/app/src/command-center/root-contributions.test.ts packages/app/src/i18n/resources.test.ts --bail=1

Test Files  5 passed (5)
Tests       260 passed (260)

Browser tests

$ npm run test:e2e --workspace=@getpaseo/app -- e2e/browser/command-center-grouping.spec.ts --grep "cycles sidebar grouping|keeps grouping"

2 passed

$ npm run test:e2e --workspace=@getpaseo/app -- e2e/browser/sidebar-project-filter.spec.ts --grep "pins the sidebar"

1 passed

$ npm run test:e2e --workspace=@getpaseo/app -- e2e/browser/sidebar-mobile-menu-sheets.spec.ts --grep "sidebar header Search"

1 passed

The browser coverage verifies:

The icon and tooltip show the current grouping.
Cmd/Ctrl+; cycles both grouping modes.
The accessibility label identifies the current mode and switcher behavior.
Display preferences retains both grouping choices and stays synchronized with the quick toggle.
Project filtering remains correct across grouping modes.
Search closes the compact sidebar before opening.

Repository checks

$ npm run format
Finished successfully

$ npm run format:check
All matched files use the correct format

$ npm run lint
Found 0 warnings and 0 errors

$ npm run typecheck --workspace=@getpaseo/app
Exit code 0

The repository-wide typecheck reaches only the existing desktop Electron clipboard errors:

packages/desktop/src/main.ts(17,3): Electron has no exported member ClipboardItem
packages/desktop/src/main.ts(539,29): any[] is incompatible with Data

Automated review

Greptile reviewed commit 82f770b8a with confidence 5/5 and reported no actionable failures.

Visual evidence

Platform coverage

Platform	Tested	Notes
iOS	Yes	Manual
Android	No	Not tested
Web	Yes	Manual and automated browser coverage
Desktop macOS	Yes	Manual
Desktop Windows	No	Not tested
Desktop Linux	No	Not tested

Checklist

chatgpt-codex-connector · 2026-09-05T14:05:38Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-05T14:09:36.104798Z	`9effa44`	PR opened
🔒 Security Review	✅ Completed 2026-09-05T14:08:42.068017Z	`9effa44`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

greptile-apps · 2026-09-05T14:08:13Z

Greptile Summary

This PR adds direct sidebar grouping controls while retaining synchronization with Display preferences and the Command Center.

Adds a Workspaces-header toggle with localized current-state tooltip and accessibility text.
Adds a configurable Cmd/Ctrl+; shortcut routed through the keyboard action dispatcher.
Moves compact-sidebar Search into the Workspaces header and closes the sidebar before opening Search.
Adds unit and browser coverage for grouping transitions, persistence, menu synchronization, keyboard handling, and compact navigation.

Confidence Score: 5/5

The PR appears safe to merge because no new actionable failures remain in the changes since the previous review.

The current code addresses the outstanding icon-semantic concern by consistently presenting the icon and tooltip as the current grouping state. The nine earlier threads were manually resolved without explanatory replies; their underlying concerns are addressed in the current code, including idempotent helpers, localization, approved theme access, focused-surface shortcut exclusions, shifted-layout handling, cleanup structure, named props, and user-level E2E helpers.

Important Files Changed

Filename	Overview
packages/app/src/components/left-sidebar.tsx	Adds localized Search and current-grouping actions to the Workspaces header, including compact-sidebar behavior.
packages/app/src/keyboard/keyboard-shortcuts.ts	Registers the grouping shortcut, excludes editable and terminal focus, and accommodates shifted keyboard layouts.
packages/app/src/command-center/root-registration.tsx	Registers the global grouping action and exposes its resolved shortcut in the Command Center.
packages/app/src/stores/sidebar-view-store.ts	Centralizes cycling between project and status grouping modes.
packages/app/e2e/browser/command-center-grouping.spec.ts	Covers shortcut cycling and synchronization between the quick toggle and Display preferences.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Header[Workspaces header toggle] --> Store[Sidebar view store]
  Shortcut[Cmd/Ctrl + semicolon] --> Dispatcher[Keyboard action dispatcher]
  Dispatcher --> Store
  Command[Command Center action] --> Store
  Preferences[Display preferences] --> Store
  Store --> Project[Project grouping]
  Store --> Status[Status grouping]

_{Reviews (11): Last reviewed commit: "docs: restore grouping menu example" | Re-trigger Greptile}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9effa447e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

greptile-apps · 2026-09-06T06:44:59Z

+      ? "shell.commandCenter.groupByProject"
+      : "shell.commandCenter.groupByStatus",
+  );
+  const Icon = groupMode === "project" ? Folder : CircleDashed;


Icon Contradicts Toggle Action

The label and click behavior describe the available action, but the icon now represents the current mode. For example, project grouping shows a Folder while the button says and performs “Group by status,” giving sighted users conflicting cues about what activating it will do.

Suggested change

const Icon = groupMode === "project" ? Folder : CircleDashed;

const Icon = targetMode === "project" ? Folder : CircleDashed;

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

feat(app): add direct sidebar grouping toggle

9effa44

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/e2e/support/helpers/sidebar.ts Outdated

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

panrafal added 2 commits September 5, 2026 17:34

fix(app): address sidebar toggle review feedback

f27486e

feat(app): add sidebar grouping shortcut

363fd25

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/src/keyboard/keyboard-shortcuts.ts

test(app): verify grouping shortcut icon updates

5c17b48

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/e2e/browser/command-center-grouping.spec.ts Outdated

fix(app): refine sidebar grouping shortcut

1171101

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/src/keyboard/keyboard-shortcuts.ts

Comment thread packages/app/e2e/browser/command-center-grouping.spec.ts Outdated

fix(app): address grouping shortcut review

fc914ea

greptile-apps Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread packages/app/src/components/left-sidebar.tsx Outdated

panrafal added 2 commits September 6, 2026 01:15

refactor(app): name sidebar action props

1acb884

fix(app): sync sidebar grouping controls

c2ff7e4

greptile-apps Bot reviewed Sep 6, 2026

View reviewed changes

fix(app): clarify grouping toggle state

475f737

greptile-apps Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread packages/app/e2e/browser/command-center-grouping.spec.ts

panrafal added 2 commits September 6, 2026 08:58

test(app): simplify grouping browser flows

6288e79

docs: restore grouping menu example

82f770b

Navigation Menu

Uh oh!

Uh oh!

Add direct workspace grouping toggle for quick switching between Projects and Statuses - #4359

Add direct workspace grouping toggle for quick switching between Projects and Statuses#4359
panrafal wants to merge 11 commits into
getpaseo:mainfrom
panrafal:sidebar-grouping-toggle

panrafal commented Sep 5, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot commented Sep 5, 2026 •

edited

Loading

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Sep 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	const Icon = groupMode === "project" ? Folder : CircleDashed;
	const Icon = targetMode === "project" ? Folder : CircleDashed;

Uh oh!

Uh oh!

Conversation

panrafal commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Linked issue

Type of change

Reasoning

Goals

Non-goals

QA

Focused unit tests

Browser tests

Repository checks

Automated review

Visual evidence

Platform coverage

Checklist

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

greptile-apps Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

panrafal commented Sep 5, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 5, 2026 •

edited

Loading

greptile-apps Bot commented Sep 5, 2026 •

edited

Loading