openapi3filter: prefer non-empty value for repeated scalar query params#1231
Merged
fenollp merged 2 commits intoJul 23, 2026
Merged
Conversation
… params When a scalar query parameter is supplied multiple times and the first value is empty, decode the first non-empty occurrence so allowEmptyValue cannot skip schema validation of a later invalid value (getkin#1230).
fenollp
requested changes
Jul 23, 2026
Address review: keep the repeated-scalar preference logic with a short human comment only.
Contributor
Author
|
Thanks for the review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a scalar query parameter is repeated and the first value is empty, decode the first non-empty occurrence instead of always taking
values[0].Why
With
allowEmptyValue: true, an empty first value short-circuits schema validation. That made order-dependent results:?dateOfBirth=&dateOfBirth=not-a-datewas accepted?dateOfBirth=not-a-date&dateOfBirth=was rejectedA single empty value still works as before (#1228 / #1134).
Fixes #1230.
Test
TestIssue1230TestIssue1134