Fix saved simulation reloads and live-viewer cancellation - #62
Draft
georgeoshardo wants to merge 1 commit into
Draft
Fix saved simulation reloads and live-viewer cancellation#62georgeoshardo wants to merge 1 commit into
georgeoshardo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root causes
Pymunk unpickles constraints by calling the concrete subclass with its serialized base constructor arguments. The SyMBac wrappers only accepted
(segment_a, segment_b, config), so loading a realspace_timeseries.praisedTypeError.The live-viewer cleanup waited at most one second for the worker, then always wrote canonical artifacts. A slow in-progress frame could therefore keep mutating simulation state while a partial run was saved as complete.
Validation
pixi run pytest -q tests/test_simulation_persistence.py tests/test_live_viewer.py tests/test_simcell_core.py tests/test_division_manager_split.py— 19 passedpixi run pytest -q— 65 passed, with the existing CPU FFT fallback warning fromSyMBac/renderer.py