Fix trench boundary handling and image cropping - #59
Draft
georgeoshardo wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The previous containment floor did not follow the cap curve, so cells could overlap the closed end. Trench wall extraction zipped independent Pymunk collections and then assumed the two largest static shapes were the walls, which fails for short trenches and additional static geometry. Crop bounds mixed inclusive maxima with Python exclusive slices, and same-parity width handling shifted centered crops left by one pixel.
Validation
pixi run pytest tests/test_drawing.py tests/test_microfluidic_geometry.py tests/test_trench_geometry.py tests/test_simulation_persistence.py tests/test_renderer_mask_export.py -q— 30 passed, 1 existing CPU-fallback warningpixi run pytest— 76 passed, 1 existing CPU-fallback warning