SUP-19876: Fix the regression of missing content staging status icons - #822
Merged
Conversation
plyhun
commented
Jun 25, 2026
| }); | ||
|
|
||
|
|
||
| test.describe('Content Staging', () => { |
Contributor
Author
There was a problem hiding this comment.
As usual, the UT won't work until the fix is released and packed into the container.
Member
There was a problem hiding this comment.
You can run the tests locally, with full UI to test with npm run e2e editor-ui -- --ui
deckdom
reviewed
Jul 8, 2026
| const folderItems = await folderList.locator('item-list-row').all(); | ||
| for (const item of folderItems) { | ||
| await expect(item.locator('.status-label icon')).toBeVisible(); | ||
| await expect(item.locator('.status-label')).toHaveText('Nicht beinhaltet'); |
Member
There was a problem hiding this comment.
Never test against text values like this, as this is a translation string, and would break if the language is different.
Already the case, since on default the tests will be run in English as UI language.
Use classes or other identifiers to determine the state.
If you need some/they aren't present, simply add them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.