Add component tests for MarkdownRenderer and BooksView#30
Merged
Conversation
- MarkdownRenderer: markdown rendering, fontSize class mapping, heading anchors, image max-height injection, code highlighting, reading-layout class, and wiki-link conversion (enabled/disabled). ~90% coverage. - BooksView: load-on-mount, empty state, book-list rendering, click-to- navigate, cover-load error handling, and the create-book modal flow (auto-generated id). ~84% coverage. Both use the jsdom + @vue/test-utils harness with mocked composables/ router. Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starts growing
.vuecomponent coverage using the jsdom +@vue/test-utilsharness.components/MarkdownRenderer.vueviews/BooksView.vueMarkdownRenderer.spec.tsPure presentational component — markdown → HTML,
fontSizeclass mapping, heading anchor ids/links, imagemax-heightinjection, code highlighting,readingLayoutclass, and wiki-link conversion (enabled vs disabled).BooksView.spec.tsMocks
useBooks/useImageLibrary/vue-router: load-on-mount, empty state, list rendering, click-to-navigate (router.push), cover-load error handling, and the create-book modal form (title → auto-generated id →createBook).Testing
npm run lint,type-check, andvitest runpass (Node 22). Full suite: 291 tests across 32 files.🤖 Generated with Claude Code