Skip to content

Unify detail cards and fix browser database startup#24

Merged
catherineluse merged 3 commits into
mainfrom
codex/consistent-detail-cards
Jul 16, 2026
Merged

Unify detail cards and fix browser database startup#24
catherineluse merged 3 commits into
mainfrom
codex/consistent-detail-cards

Conversation

@catherineluse

Copy link
Copy Markdown
Collaborator

Summary

  • align chapter and wiki detail sidebar cards on the same white / dark gray-800 surface colors
  • add consistent spacing between the chapter title/action header and the detail content grid
  • resolve SQL.js to the WASM asset that the project actually bundles, restoring local browser database initialization

Why

Illustration and text-size panels used a darker surface than linked wiki and information cards, making the right column look inconsistent. The content grid also began directly against the chapter header border.

While verifying the UI in the correct worktree, SQL.js failed because its browser entry requested sql-wasm-browser.wasm, while the project copies sql-wasm.wasm. Vite returned index.html for the missing filename, causing the WebAssembly <!DOCTYPE> compile error. The two SQL.js package files are the same binary, so initialization now explicitly resolves to the bundled asset.

Validation

  • TypeScript typecheck passed
  • ESLint passed for all changed files
  • Vite production build passed
  • fresh-browser /books load passed with no console errors
  • 23 test files / 194 tests passed locally
  • four additional jsdom suites could not start because this linked worktree shares a dependency directory owned by an older checkout without the already-declared jsdom package; no test assertions failed, and CI will install dependencies from this branch's current manifest

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-beta-reader-frontend Ready Ready Preview, Comment Jul 16, 2026 5:52am

Request Review

@catherineluse
catherineluse marked this pull request as ready for review July 16, 2026 05:53
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/database.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@catherineluse
catherineluse merged commit 626bdef into main Jul 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants