Feature/index existing#3
Open
YoSiJo wants to merge 10 commits into
Open
Conversation
Owner
|
Hello YoSiJo, Thank you for your input. I will check it will you have commit so far |
Owner
|
Hello YoSiJo, Your idea is cool, I like it and there is something that I have not think of it. To be honest with you I cover it partially, but not fully as your suggestion. I run tests in CLI and GUI for bugs or any breaks, tests, and I will ship it in the next release. Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, this is VipeCoded, where I tried to learn through more and more Python and looked at the points and tested them.
As far as I can see, and as far as the tests were concerned, this should correspond to my objective and be beneficial to the project here.
The whole thing should cover the case if you already have an existing file system, with many duplicates.
I have deliberately divided it into two options, because the goal of the fastest possible copying should be beneficial, while the second offers an added value from the hash effort.
--index-existingThis implements a scan of the target, but only the size of the data.
If the program does not find a hash when executing a file, it still checks whether it finds a file in the existing files with the same size and hashes it until it has found one with the matching hash, i.e. all of them.
A hashed file simply transfers it into the known table.
--dedup-existingThis is a small extra function that comes into play when a file hashed because it was the same size in the target and is therefore transferred from one table to the other.
He now checks whether the hash has already occurred in the table and then applies if necessary.
FIDEDUPERANGEDeposits.Ps. I would understand if the VipeCoding topic were a reason for rejection, but I also wanted to not lose the idea approach and at least bring the MR to the project.