add rate limiting for api/chat endpoint - #513
Open
aboullaite wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mohammed Aboullaite <[email protected]>
✅ Deploy Preview for next-gb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Mohammed Aboullaite <[email protected]>
aminerachyd
reviewed
May 8, 2025
| } | ||
| } catch { | ||
| // Don't throw the error - we want the chat to work even if storage fails | ||
| // The rate limiter will handle invalid IDs appropriately |
Contributor
There was a problem hiding this comment.
If we're explicitely deciding not to handle the exception, might aswell remove the try/catch block no ? Unless it's mandated by the compiler
Contributor
Author
|
@yjose dreb tlila meli rje3ti hahah |
Member
|
@aboullaite, is there a specific reason you chose to use fingerprinting instead of the user's IP address? At least this is what they recommend in the docs. |
Contributor
Author
|
@yjose Ip can be easily altered and changed. Fingerprinting is more resilient afaik |
yjose
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some users abused the usage of the chat endpoint which blow up our infrastructure. We are adding a basic rate limiter to hopefully stop them from abusing it