Skip to content

Simplify vcs import#690

Merged
azeey merged 3 commits into
gazebosim:masterfrom
jmachowinski:patch-1
Jul 1, 2026
Merged

Simplify vcs import#690
azeey merged 3 commits into
gazebosim:masterfrom
jmachowinski:patch-1

Conversation

@jmachowinski

@jmachowinski jmachowinski commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Simplified source installation.

vcs supports import directly from upstream http location, not need for the curl command.

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

vcs supports import directly from upstream http location, not need for the curl command.

Signed-off-by: Janosch Machowinski <[email protected]>

@azeey azeey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Would you mind updating the file in other releases as well?

@github-actions github-actions Bot added 🌱 garden Gazebo Garden 🎵 harmonic Gazebo Harmonic 🏛️ ionic 🏯 fortress Ignition Fortress labels Jun 30, 2026
@jmachowinski

Copy link
Copy Markdown
Contributor Author

Told the AI to update everything from fortress onwards.

vcs import --input with http support was added around 2020 with the VCS PR: 155

@j-rivero

j-rivero commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Thanks for the update. As a side note, the infra team has migrated from using vcstools to vcs2l https://github.com/ros-infrastructure/vcs2l/ which supports the same interface and parameters. Not to change it in this PR but a nice follow-up.

@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Jul 1, 2026
@azeey azeey merged commit 2b536ac into gazebosim:master Jul 1, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants