Renamed EffectInfoResolver into EffectStackDataResolver.#44
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the statescript resolver and related APIs to better reflect that the queried data is stack/application aggregate data, and updates all in-repo usages (tests + docs) accordingly.
Changes:
- Renamed
EffectInfoResolver→EffectStackDataResolverandEffectInfoType→EffectStackDataType. - Renamed
EffectsManager.GetEffectInfo(...)→GetEffectStackData(...). - Updated tests and documentation references/examples to the new names.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Forge/Statescript/Properties/EffectStackDataType.cs | Renames the enum used to select which stack aggregate to compute. |
| Forge/Statescript/Properties/EffectStackDataResolver.cs | Renames the resolver and updates it to call GetEffectStackData. |
| Forge/Effects/EffectsManager.cs | Renames the manager query method to GetEffectStackData and updates summary docs. |
| Forge.Tests/Statescript/Resolvers/ActiveEffectResolverTests.cs | Updates resolver test to use the new resolver/type names. |
| Forge.Tests/Statescript/Nodes/State/EffectNodeTests.cs | Updates test assertions to call GetEffectStackData. |
| Forge.Tests/Statescript/Nodes/Action/ApplyEffectNodeTests.cs | Updates test assertions to call GetEffectStackData. |
| Forge.Tests/Effects/TargetTagRequirementsComponentTests.cs | Updates stack data assertions to call GetEffectStackData. |
| Forge.Tests/Effects/EffectsTests.cs | Updates stack data assertions to call GetEffectStackData. |
| docs/statescript/resolvers/README.md | Updates resolver list entry to the new resolver name/link. |
| docs/statescript/resolvers/query-active-effects-resolver.md | Updates “See also” link to the renamed resolver doc. |
| docs/statescript/resolvers/effect-stack-data-resolver.md | Updates the resolver documentation to reflect new names and API usage. |
| docs/effects/README.md | Updates docs reference from GetEffectInfo to GetEffectStackData. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lextatic
added
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed