harmonise import hydrography, fixup to work with/without Copernicus login #82
Merged
Conversation
Without access to data, there isn't much that can be done. Make all sections dependent on them being set.
lentinj
force-pushed
the
fixup-copernicus-login
branch
from
June 14, 2026 20:38
7743f3f to
e1a6153
Compare
CMD check runs in an isolated environment, so packages aren't available. Whilst we could remove this, it seems cleaner to test this separately by rebuilding just the vignettes with a key handy.
lentinj
force-pushed
the
fixup-copernicus-login
branch
from
June 16, 2026 20:25
bb4f44e to
da0988c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Yes, I finally got around to looking at this!)
As well as @vbartolino 's changes from #81, fix-up the vignette so it doesn't run unless a login was provided. Provide the credentials so we test the vignette when being built on GitHub.
Supersedes #81