Fix binomial SE fallback with SVD pseudo-inverse#259
Conversation
|
@Lillyakasiken : can you check how to pass the R_CMD_check_passed? I've approved your changes but I cannot issue this check (the others chould be checked and pass). |
The check hasn't been triggered because the CRAN::check label hasn't been applied. |
|
test-coverage: https://github.com/furrer-lab/abn/actions/runs/27133785812/job/80083378275#step:6:433 1 & 2. tests/testthat/test-build_score_cache_bayes.R:26 — buildScoreCache.bayes() 3. tests/testthat/test-tographviz.R:181 — duplicate snapshot file name |
Summary
irls_binomialpost-processing that usedsqrt(svd()$d)instead of a proper SVD-based pseudo-inverse, producing mathematically inverted standard errors whensolve()fails on near-singular Fisher information matrices.Closes #246
Test plan
solve()on well-conditioned PSD matricessolve()on realistic logistic XtWXsolve()on real abn binomial node varcovfitAbnreturns finite positive SEs on near-singular varcov