feat(tasks): English PR text + dedup pre-flight for suggestions/changelog#18
Open
havardljohansen wants to merge 1 commit into
Open
feat(tasks): English PR text + dedup pre-flight for suggestions/changelog#18havardljohansen wants to merge 1 commit into
havardljohansen wants to merge 1 commit into
Conversation
…elog Two task files were the only ones missing both rules that the rest already have. Symptoms observed in production: - 2026-05-18: merkur-frontend produced PR titled `night-shift/suggestions: opprett forbedringsforslag` (nynorsk). PR-internal text should be English so anyone in the company can review. - Unmonitored repos accumulate one suggestions / changelog PR per night with no dedup, where other tasks (a11y, seo, perf, security, bug, tests, translate-ui, dep-audit) already exit silently if an open PR exists. Changes: - tasks/suggest-improvements.md: add pre-flight gh-pr-list check + language section distinguishing PR-internal (English) from docs/SUGGESTIONS.md content (project's configured Doc language). - tasks/update-changelog.md: same two additions. - skills/night-shift/SKILL.md: bump NIGHT_SHIFT_VERSION 2026-05-19b → 2026-05-20a per AGENTS.md rule on framework-level changes. Follow-up observations were captured in this user's local IMPROVEMENTS.md 2026-05-20 entry. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two task files (
suggest-improvements.md,update-changelog.md) were the only ones missing both rules the rest of the suite already encodes:gh pr list --search "night-shift/<slug> in:title" --state open→ exit silently if one exists) — 7 of 9 PR-creating tasks have it. These two didn't.Why this matters
Symptom that triggered the audit (2026-05-18): merkur-frontend (a nynorsk-mixed Sanity site) produced a PR titled
night-shift/suggestions: opprett forbedringsforslag(nynorsk). Hard to triage if you don't read nynorsk.Without the dedup pre-flight, an unmonitored repo accumulates one suggestions PR every night until someone triages — could be 7+ PRs per week. With the pre-flight (matching the other tasks' pattern), the second night's run exits silently and the existing PR sits until merged or closed.
Distinction preserved
PR-internal text (title, body, commit messages) → English.
Content written into repo docs (
docs/SUGGESTIONS.md,CHANGELOG.mdentries themselves) → project's configuredDoc language:, because that's editor- or end-user-facing.Changes
tasks/suggest-improvements.md— pre-flight + language sections added after "Read project config first"tasks/update-changelog.md— same two additionsskills/night-shift/SKILL.md— bumpNIGHT_SHIFT_VERSION2026-05-19b → 2026-05-20a perAGENTS.mdrule on framework-level changesTest plan
🤖 Generated with Claude Code