Windows portability: verify the full suite on CI (#11)#15
Merged
Conversation
… shell git runs GIT_SEQUENCE_EDITOR/GIT_EDITOR through a POSIX shell (its bundled sh on Windows), which accepts forward slashes but mishandles backslash separators. Route every editor command path (cp-based todo/message editors and the current_exe reorder/stamp editors) through a shell_path() helper that normalises separators. No-op on Unix. Also flip the Windows CI job from --lib-only to the full test suite so the git-driven rebase machinery is actually exercised.
The one Windows failure was a test artifact, not a product bug: git-for-windows defaults core.autocrlf=true, so a checked-out `v2\n` file reads back as `v2\r\n` and a working-tree byte assertion failed. Pin autocrlf/eol in the hermetic repo setup so disk-content assertions hold on every platform.
Windows portability is now verified end-to-end (full test suite green on windows-latest / git 2.55, 0 skips), so add x86_64-pc-windows-msvc to dist targets and the powershell installer. Release now produces git-queue-x86_64-pc-windows-msvc.zip and git-queue-installer.ps1. Docs: website Install section shows the PowerShell installer for Windows and includes Windows in the prebuilt-binary card; drops the 'source-only, #11' note. README documents the PowerShell installer. Closes #11.
freshtonic
marked this pull request as ready for review
July 25, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifying git-queue on real Windows before shipping a Windows binary (#11).
shell_path()(forward slashes) so git's bundledshhandles them.--lib.Draft until Windows CI is green; then I'll add the Windows target + PowerShell installer to dist.