Insert menu context menu#19
Open
Muaz-T wants to merge 2 commits into
Open
Conversation
Collaborator
|
Types are a little weird since a configuration only makes sense for an ElementPath (as a Document/Version can't be configured). I wonder if updating ConfigurablePath to extend ElementPath, updating makeUrl to include a ConfigurablePath, and then updating your component to take an InstancePath | ElementPath | ConfigurablePath (or just InstancePath if eslint gets uppity) would solve the issue. |
Collaborator
|
You could also optionally define a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added context menu to insert menu, moved MenuButton to app-menu.tsx, and made it so it open document/copy url saves the current configuration