ci: backport claude-code-review workflow onto SDTD_040_beta_release#11
Merged
Merged
Conversation
SDTD_040_beta_release only had release.yml, so forkni-internal PRs targeting it (e.g. #9) had no automated CI gate at all -- GitHub resolves pull_request workflows from the base branch's copy, and this repo's Claude review workflow lived only on SDTD_032_dev's branches list. Copies the workflow verbatim and adds SDTD_040_beta_release to its branches filter so PRs into the release line get the same review gate as PRs into dev. This PR itself can't be CI-gated (the base branch doesn't have the workflow until this merges) -- infra-only change, verified by YAML parse + diff review against the working SDTD_032_dev copy.
forkni
added a commit
that referenced
this pull request
Jul 19, 2026
forkni
added a commit
that referenced
this pull request
Jul 19, 2026
…ws MAX_PATH (#9) * fix: hash UNet engine cache key so ONNX export path stays under Windows MAX_PATH EngineManager.get_engine_path encoded every UNet build flag verbatim into the on-disk directory name. With a realistic engine_dir (fp8 + static batch + pin_cache_frames + optlvl + resolution), the folder grew to 246 chars, and the derived unet.engine.onnx / unet.engine.opt.onnx paths hit 263/267 chars -- over Windows' 260-char MAX_PATH. Because the *directory* fit but the *file* didn't, mkdir succeeded while torch.onnx.export's open(onnx_path, "wb") raised FileNotFoundError, which wrapper.py's OOM-only fallback doesn't catch, so the build failed with "Acceleration has failed: [Errno 2] No such file or directory: ...unet.engine.onnx". Fix: for EngineType.UNET only, hash the fully-assembled flag prefix (sha1, first 12 hex chars) using the existing _lora_signature hashing idiom, keeping model name + fp8 + resolution human-readable in the folder name. Cache-key precision is unchanged (identical configs still hash identically, differing configs still diverge) -- only the on-disk encoding is compacted, from ~267 chars down to ~132. VAE/ControlNet directory naming is untouched, so existing VAE engines are not invalidated; UNet engines rebuild once under their new hashed folder name. Also adds a belt-and-suspenders warning if a derived path would still approach MAX_PATH (e.g. an unusually deep user engine_dir), and casts the "filename" config lookup to str to keep the type checker precise about self._configs' heterogeneous per-key value types. Adds a regression test (test_engine_path_length.py) that reproduces the exact crash-log config and asserts the derived .onnx / .opt.onnx paths stay under MAX_PATH, plus determinism and no-collision checks. Co-Authored-By: Claude Opus 4.8 <[email protected]> * ci: trigger review workflow now that SDTD_040_beta_release has the CI gate (see #11) --------- Co-authored-by: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SDTD_040_beta_releaseonly carriesrelease.yml— theclaude-code-review.ymlgate used bySDTD_032_dev(and every forkni-internal PR merged there this cycle) was never backported, so PRs targeting the release branch (e.g. #9) get no automated CI at all: GitHub resolvespull_requestworkflows from the target/base branch's copy, and the file simply didn't exist there..github/workflows/claude-code-review.ymlfromSDTD_032_devverbatim.SDTD_040_beta_releaseto itsbranches:filter (previously scoped only toSDTD_032_dev+ its own chained remediation-PR branches), so PRs into the release line now get the same review gate.Why this can't itself be CI-gated
Chicken-and-egg: the base branch doesn't have this workflow until this PR merges, so no
pull_requestrun can fire against this PR. Verified instead via YAML parse (python -c "import yaml; yaml.safe_load(...)"— OK) and a direct diff against the known-workingSDTD_032_devcopy (only thebranches:list changed).Test plan
SDTD_032_dev's working copy — only the branches filter changed🤖 Generated with Claude Code