Fix security vulnerabilities found by code quality scan#909
Open
sreckoskocilic wants to merge 7 commits into
Open
Fix security vulnerabilities found by code quality scan#909sreckoskocilic wants to merge 7 commits into
sreckoskocilic wants to merge 7 commits into
Conversation
…paring two tuples, every equality check returns True - master -> main branch fix - prepare_trash now calls self.move_to_trash instead of self.delete, so plugin subclasses won't permanently delete files when the user expects trashing - NotImplementedError - unrecognized platforms fail fast with a clear message instead of a cryptic NameError - removed shadowing basename import - get_column_widths uses range so plugin-added columns get their widths saved/restored
…it__ always runs, even on exception. - util/qt/__init__.py — Added missing c_void_p import from ctypes, fixing a macOS runtime crash. - table.py — Fixed off-by-one: bounds check now rejects len + 1 correctly. - widgets.py — Added null guard on _main_window before accessing it in state change handler.
…ved, so a/b/c/../../d correctly becomes a/d. - session.py — Removed dead _get_startup_message method (duplicated by _show_startup_messages)
- os_.py: whitelist allowed Popen kwargs to prevent shell injection via user JSON settings - os_.py: return empty string when /etc/os-release has no NAME= entry - github.py: add timeout=30 to urlopen and requests.get preventing GUI hangs and socket leaks - post-commit: replace hardcoded API secret with $FMAN_API_SECRET env var - base.txt: fetch fbs dependency over HTTPS instead of HTTP - windows.json: replace dead Symantec timestamp server with DigiCert - fman.repo: enable gpgcheck and add gpgkey for RPM package verification - commands/__init__.py: reject plugin names containing path separators or '..' - build_impl/__init__.py: validate record_release_url uses HTTPS, add request timeout, chmod check=True, exclude .git from cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post-commithook replaced withFMAN_API_SECRETenvironment variable; hook exits early if unsetfbspackage download URL inrequirements/base.txtInstallPlugin— reject plugin names containing..,/, oros.sepurlopenandrequests.getcalls ingithub.pyandbuild_impl/__init__.pyrecord_release_urlbefore posting secretsos_.py— onlyargs,cwd,env,startupinfoare forwarded from plugin settingsgpgcheck=1with agpgkeyURLsymantec→digicert) in Windows signing configchmod 600on SSH key now usescheck=Trueto fail fast on errorTest plan
post-commithook skips gracefully whenFMAN_API_SECRETis unset