Make api and well known ingresses have configurable hosts - #7801
Merged
Conversation
Signed-off-by: Jason Parraga <[email protected]>
pingsutw
previously approved these changes
Aug 7, 2026
pingsutw
left a comment
Member
There was a problem hiding this comment.
Looks good. Let’s wait for GitHub Actions to recover.
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
enabled auto-merge (squash)
August 7, 2026 05:55
pingsutw
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
With
ingress-nginxyou cannot have multiple ingresses with the same hosts and the same routes. The http ingress and the api-jwt conflict in that regard.ie.
Additionally, it may be nice to have ingresses on different hosts (ie. api.flyte2.internal.com, flyte2.internal.com, oauth.flyte2.internal.com)
What changes were proposed in this pull request?
This pull request allows each ingress to have a configurable host such that you can run them on different sub domains (ie. different hosts).
Empty strings are falsy in helm so this change is completely backwards compatible and does not change the default behavior.
How was this patch tested?
Untested but pretty straightforward...
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link