Skip to content

Make api and well known ingresses have configurable hosts - #7801

Merged
Sovietaced merged 2 commits into
flyteorg:mainfrom
Sovietaced:ingress-conflicts
Aug 7, 2026
Merged

Make api and well known ingresses have configurable hosts#7801
Sovietaced merged 2 commits into
flyteorg:mainfrom
Sovietaced:ingress-conflicts

Conversation

@Sovietaced

@Sovietaced Sovietaced commented Aug 6, 2026

Copy link
Copy Markdown
Member

Why are the changes needed?

With ingress-nginx you cannot have multiple ingresses with the same hosts and the same routes. The http ingress and the api-jwt conflict in that regard.

ie.

one or more synchronization tasks completed unsuccessfully, reason: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: host "<redacted>" and path "/flyteidl2.workflow.RunService" is already defined in ingress flyte-v2/flyte-v2-flyte-binary-http

Additionally, it may be nice to have ingresses on different hosts (ie. api.flyte2.internal.com, flyte2.internal.com, oauth.flyte2.internal.com)

What changes were proposed in this pull request?

This pull request allows each ingress to have a configurable host such that you can run them on different sub domains (ie. different hosts).

Empty strings are falsy in helm so this change is completely backwards compatible and does not change the default behavior.

How was this patch tested?

Untested but pretty straightforward...

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

@Sovietaced Sovietaced added added Merged changes that add new functionality helm labels Aug 6, 2026
@Sovietaced
Sovietaced marked this pull request as ready for review August 6, 2026 22:44
@github-actions github-actions Bot added the flyte2 label Aug 6, 2026
pingsutw
pingsutw previously approved these changes Aug 7, 2026

@pingsutw pingsutw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let’s wait for GitHub Actions to recover.

Signed-off-by: Jason Parraga <[email protected]>
@Sovietaced
Sovietaced merged commit d52a683 into flyteorg:main Aug 7, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

added Merged changes that add new functionality flyte2 helm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants