Switch to debug instead of warn - #7721
Merged
Merged
Conversation
Signed-off-by: Carina Ursu <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise in the dataproxy literal/json conversion layer by downgrading “ignored mismatch” logs from Warn to Debug, aligning with the expectation that unmapped inputs can occur during task version switches in the launch form.
Changes:
- Switch
JSONValuesToLiteralsunmapped-field logging fromWarnftoDebugf. - Switch
LiteralsToLaunchFormJson“skipping literal with no corresponding variable” logging fromWarnftoDebugf.
Comments suppressed due to low confidence (1)
dataproxy/converter/literal_json_converter.go:397
- This comment says the literal is skipped "with a warning", but the code now uses logger.Debugf. Update the comment so it matches the behavior.
// versions): inputs the new task def dropped have nowhere to map. Skip
// them (with a warning) instead of failing the whole conversion, so the
// inputs the two versions *share* are still preserved. Mirrors the
// unmapped-field handling in JSONValuesToLiterals.
logger.Debugf(ctx, "skipping literal %q with no corresponding variable in the target interface (ignoring)", literal.GetName())
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ursucarina
enabled auto-merge (squash)
July 28, 2026 18:52
wild-endeavor
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Related to #7719
Why are the changes needed?
The launch-form converter intentionally ignores inputs that don't map to the target interface when re-converting a run's inputs against a different task version. The two "ignored mismatch" log lines were at
Warn, but this is expected during a version switch, not a warning.What changes were proposed in this pull request?
Lowered both "ignored mismatch" logs in
LiteralsToLaunchFormJsonandJSONValuesToLiteralsfromWarntoDebug. No behavior change.How was this patch tested?
go test ./dataproxy/converter/...— passing (logging-only; existing tests unaffected).Labels
changed
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#7719
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link