Skip to content

Switch to debug instead of warn - #7721

Merged
ursucarina merged 1 commit into
mainfrom
carina/switchtodebug
Jul 28, 2026
Merged

Switch to debug instead of warn#7721
ursucarina merged 1 commit into
mainfrom
carina/switchtodebug

Conversation

@ursucarina

@ursucarina ursucarina commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Tracking issue

Related to #7719

Why are the changes needed?

The launch-form converter intentionally ignores inputs that don't map to the target interface when re-converting a run's inputs against a different task version. The two "ignored mismatch" log lines were at Warn, but this is expected during a version switch, not a warning.

What changes were proposed in this pull request?

Lowered both "ignored mismatch" logs in LiteralsToLaunchFormJson and JSONValuesToLiterals from Warn to Debug. No behavior change.

How was this patch tested?

go test ./dataproxy/converter/... — passing (logging-only; existing tests unaffected).

Labels

changed

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#7719

Stack

If you do use git town to manage PR Stacks, the stack relevant to this PR
will show below. Otherwise, you can ignore this section.

Docs link

Copilot AI review requested due to automatic review settings July 28, 2026 18:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise in the dataproxy literal/json conversion layer by downgrading “ignored mismatch” logs from Warn to Debug, aligning with the expectation that unmapped inputs can occur during task version switches in the launch form.

Changes:

  • Switch JSONValuesToLiterals unmapped-field logging from Warnf to Debugf.
  • Switch LiteralsToLaunchFormJson “skipping literal with no corresponding variable” logging from Warnf to Debugf.
Comments suppressed due to low confidence (1)

dataproxy/converter/literal_json_converter.go:397

  • This comment says the literal is skipped "with a warning", but the code now uses logger.Debugf. Update the comment so it matches the behavior.
			// versions): inputs the new task def dropped have nowhere to map. Skip
			// them (with a warning) instead of failing the whole conversion, so the
			// inputs the two versions *share* are still preserved. Mirrors the
			// unmapped-field handling in JSONValuesToLiterals.
			logger.Debugf(ctx, "skipping literal %q with no corresponding variable in the target interface (ignoring)", literal.GetName())

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dataproxy/converter/literal_json_converter.go
@ursucarina ursucarina added the changed For changes in existing functionality label Jul 28, 2026
@ursucarina
ursucarina enabled auto-merge (squash) July 28, 2026 18:52
@ursucarina
ursucarina merged commit 85cdd90 into main Jul 28, 2026
25 of 27 checks passed
@ursucarina
ursucarina deleted the carina/switchtodebug branch July 28, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changed For changes in existing functionality flyte2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants