#2456 - add sorting schema#2459
Merged
Merged
Conversation
Add Schema::sort(SortingStrategy) with AlphabeticalStrategy (default), TypeStrategy, MetadataStrategy and CombinedStrategy in core, plus a PostgreSqlSortingStrategy (primary-key -> type -> name) in the postgresql adapter. Strategies are exposed via sort_by_name, sort_by_type, sort_by_type_and_name, sort_by_metadata and pgsql_sort_strategy DSL helpers. Resolves flow-php#2456
MrHDOLEK
commented
Jun 17, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2459 +/- ##
============================================
Coverage 85.13% 85.13%
- Complexity 0 21255 +21255
============================================
Files 1598 1605 +7
Lines 65485 65575 +90
============================================
+ Hits 55749 55826 +77
- Misses 9736 9749 +13 🚀 New features to boost your workflow:
|
…priority Drop the redundant equality guard in TypeStrategy::compare() (<=> already returns 0 for equal priorities) and replace the magic 99999 fallback with a named TypePriorities::UNKNOWN_TYPE_PRIORITY constant set to PHP_INT_MAX.
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
reviewed
Jun 18, 2026
norberttech
requested changes
Jun 18, 2026
norberttech
left a comment
norberttech
left a comment
Member
There was a problem hiding this comment.
Looks great! 💪
Just few minor namespaces and function names cleanups are required before merge
Apply review feedback from flow-php#2459: prefix core sorting DSL helpers with schema_ (schema_sort_by_name/type/type_and_name/metadata), rename pgsql_sort_strategy to pgsql_schema_sort_by_type, and move the PostgreSQL strategy to Flow\ETL\Adapter\PostgreSql\Schema\SortingStrategy\TypeStrategy.
Move Flow\ETL\Schema\SortingStrategy\TypePriorities to Flow\ETL\Schema\SortingStrategy\TypeStrategy\TypePriorities per review feedback on flow-php#2459.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Schema::sort(SortingStrategy) with AlphabeticalStrategy (default), TypeStrategy, MetadataStrategy and CombinedStrategy in core, plus a PostgreSqlSortingStrategy (primary-key ->type -> name) in the postgresql adapter. Strategies are exposed via sort_by_name, sort_by_type, sort_by_type_and_name, sort_by_metadata and pgsql_sort_strategy DSL helpers.
Change Log
Added
Flow\ETL\Schema::sort()accepting a pluggableSortingStrategy(defaults toAlphabeticalStrategy)AlphabeticalStrategy,TypeStrategy,MetadataStrategyandCombinedStrategy, exposed viasort_by_name(),sort_by_type(),sort_by_type_and_name()andsort_by_metadata()DSL helpersPostgreSqlSortingStrategy(primary-key columns first, then by PostgreSQL type, then by name) exposed via thepgsql_sort_strategy()DSL helperFixed
Changed
Removed
Deprecated
Security