fix(engine): retry transport drops and report shared capacity#2280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transient_network_errorwhile leaving unknown exceptions as non-retryable crashesSafety properties
driver.runis activerun_execution_exceptionand retain crash classificationVerification
git diff --checkpassedIndependent review
Two adversarial review rounds traced all retry callers and restart paths. The review found and prompted fixes for post-driver duplicate side-effect risk, restart-loss of delayed retries, retry-child duplication during a crash window, and false success reporting on repository insert failure. Focused regression tests cover each correction.
Related concurrency follow-up: #2279