fix(metric): substitute {PREFIX} in kube-client MetricsAdapter#875
Open
aspr0d wants to merge 1 commit into
Open
fix(metric): substitute {PREFIX} in kube-client MetricsAdapter#875aspr0d wants to merge 1 commit into
aspr0d wants to merge 1 commit into
Conversation
kube-client registers metrics with a {PREFIX} placeholder in the name.
MetricsAdapter forwarded those names unchanged, so Prometheus exposed
_PREFIX_* series on /metrics.
Apply app.PrometheusMetricsPrefix via metrics.ReplacePrefix before
registering or updating metrics in the adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #865
kube-client passes metric names containing a
{PREFIX}placeholder throughMetricsAdapter. The adapter forwarded those names unchanged, so Prometheus exposed series like_PREFIX_kubernetes_client_rate_limiter_latency_secondson/metrics.Changes
MetricsAdapternow takes the configured Prometheus metrics prefix and appliesmetrics.ReplacePrefixbefore register/add/observe callsapp.PrometheusMetricsPrefixfromkube_client.gopkg/metric/adapter_test.goVerification
go test ./pkg/metric/... -count=1