Sync Fork#19
Open
ivan-flamingo wants to merge 260 commits into
Open
Conversation
Used THIS_SCRIPT variable within wget to allow execution from any dir.
Feat success return codes
works fine
…ixes #2269 actually exclude agents when checking client and site agents
added server 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@api/tacticalrmm/alerts/models.py`:
- Around line 335-337: The new gating logic (e.g., the
should_run_script_or_webhook boolean) incorrectly requires alert_template.action
/ resolved_action for all action types and thus prevents REST-only templates
from firing; update the guards to check the appropriate fields per action type
(keep checks for alert_template.agent_script_actions and webhook flags, but also
allow REST-only templates by checking alert_template.action_rest and
resolved_action_rest where relevant), and apply the same pattern to the other
similar checks you changed (the blocks around lines referenced: 388-390,
424-426, 619-622, 647-650, 676-679) so each "should_run_*" variable validates
the specific action field(s) for script, webhook, and REST separately instead of
universally requiring alert_template.action.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 88194304-c0c7-423c-bff8-59ef3d73d7af
📒 Files selected for processing (1)
api/tacticalrmm/alerts/models.py
…solved fixes #2478 Follow-up fix for PR#2294 added Hostname to Resolved Mail & SMS
…edis memory bloat
prune superseded updates not reporting by windows api that aren't already installed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation