Fix dead quick-action chips: capture pointer lazily in MarqueeWall dragScroll#1503
Merged
Merged
Conversation
…agScroll [preview:none]
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesMarquee drag handling
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quick-action chips in the embeddable chat (
GlobalAskAIClient→GuideWelcome→QuickActionWall rows={4} dragScroll) stopped responding to clicks entirely.Root cause
#1502 added
dragScrolland calledcontainerRef.setPointerCapture(e.pointerId)on everypointerdown. Pointer capture also retargets the compatibility mouse events, somouseup— and thereforeclick, which fires at the nearest common ancestor of the down/up targets — landed on the wall container instead of the pressed chip.QuickActionChipFromDatarenders a<button onClick={onSelect}>, so its handler never ran and the whole wall read as dead.Fix
Capture lazily: only once the press crosses the existing 3px drag threshold in
onPointerMove.onDragClickCapture.onPointerLeavenow ends a pre-threshold press, sodraggingRefcan't stick true and freeze the marquee when a press escapes the wall without a capture-guaranteedpointerup.No consumer/hub change required.
Verification
tsc --noEmitclean for the touched file.🤖 Generated with Claude Code
Summary by CodeRabbit