Skip to content

Fix carousel dots + CircularProgress accent to follow platform accent#1497

Merged
michaelassraf merged 1 commit into
mainfrom
claude/media-carousel-accent-theme-8fffc0
Jul 18, 2026
Merged

Fix carousel dots + CircularProgress accent to follow platform accent#1497
michaelassraf merged 1 commit into
mainfrom
claude/media-carousel-accent-theme-8fffc0

Conversation

@michaelassraf

@michaelassraf michaelassraf commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What

Two shared components hardcoded the Flamingo brand color on state indicators that should track the platform-adaptive accent token. As a result they rendered pink/cyan on every platform instead of the platform accent (yellow on openframe/openmsp, pink only on flamingo/flamingo-teaser).

  • MediaCarousel active pagination dot: bg-ods-flamingo-pinkbg-ods-accent
  • CircularProgress accent variant: --ods-flamingo-cyan-base--ods-accent (its sibling variants success/warning/error already use their semantic tokens; accent was the odd one out)

Comments documenting the old "always pink" intent were updated to say "platform accent".

Why

ods-flamingo-pink / ods-flamingo-cyan are theme-independent brand tokens. Themed controls and state indicators should consume --ods-accent / --color-accent-primary, which ods-colors.css overrides per [data-app-type]. The reported bug was the carousel controls always showing Flamingo pink regardless of platform; this fixes that class of issue at the shared-component level.

Reviewer notes

  • Nav arrows were already correct (bg-black/50 + text-ods-text-on-dark) — untouched.
  • The MuxPlayer controls in the same carousel already read --ods-accent, so the dot now matches them.
  • Consumed in the hub via who-am-i, openframe-features-section, and vendor-detail-content. Needs the usual lib release → hub pin bump to reach production.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Updated media carousel pagination to use the accent color for the active dot.
    • Updated circular progress indicators to use the accent color for progress rings.
    • Refined related styling documentation to reflect the updated color scheme.

… [preview:none]

Two shared components hardcoded the Flamingo brand color on state
indicators that should track the platform-adaptive accent, so they
rendered pink/cyan on every platform instead of the platform accent
(yellow on openframe/openmsp, pink only on flamingo/flamingo-teaser):

- MediaCarousel active pagination dot: bg-ods-flamingo-pink -> bg-ods-accent
- CircularProgress accent variant: --ods-flamingo-cyan-base -> --ods-accent
  (siblings success/warning/error already use their semantic tokens)

Both now consume --color-accent-primary / --ods-accent, matching the
per-[data-app-type] overrides in ods-colors.css.

Co-Authored-By: Claude Opus 4.8 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 00534693-fbed-4e50-b25d-a889c5ea3ae3

📥 Commits

Reviewing files that changed from the base of the PR and between 1aca6e5 and 1b2c165.

📒 Files selected for processing (2)
  • openframe-frontend-core/src/components/media-carousel.tsx
  • openframe-frontend-core/src/components/ui/circular-progress.tsx

📝 Walkthrough

Walkthrough

Updated active media carousel dots and accent circular-progress rings to use the platform accent tokens, with corresponding comments revised.

Changes

Accent token updates

Layer / File(s) Summary
Accent indicator styling
openframe-frontend-core/src/components/media-carousel.tsx, openframe-frontend-core/src/components/ui/circular-progress.tsx
Media carousel active dots now use bg-ods-accent, and the circular progress accent ring now uses var(--ods-accent). Related comments were updated.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: pavlo-flamingo

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: updating carousel dots and CircularProgress to use the platform accent color.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/media-carousel-accent-theme-8fffc0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@michaelassraf
michaelassraf merged commit 8e76cf1 into main Jul 18, 2026
5 of 6 checks passed
@michaelassraf
michaelassraf deleted the claude/media-carousel-accent-theme-8fffc0 branch July 18, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant