Delete QUICK_ACTION_THEMES registry — quick-action theme specs are 100% caller-supplied#1496
Conversation
…100% caller-supplied
No lib-side theme names, no fallbacks: QuickActionThemeSpec ({accent, lozenge?}) is now the chip/wall theme contract, injected by the consumer per chip or as a wall default. QuickActionTheme, QUICK_ACTION_THEMES, QuickActionThemeAccents, and the themeAccent/themeAccents plumbing are all deleted. getAgentAccent stays (pre-existing chat contract used by embeddable-chat). Stories define their own demo specs.
Co-Authored-By: Claude Fable 5 <[email protected]>
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #1495 per Michael's review direction: no lib-side theme registry, no fallbacks — all theming is controlled by the caller.
What changed
QuickActionTheme(the'fae' | 'mingo' | 'it' | 'sec'union),QUICK_ACTION_THEMES,QuickActionThemeAccents, and thethemeAccent/themeAccentsoverride plumbing added in Unify all marquees on one rAF engine: MarqueeWall + QuickActionWall + fae/mingo/it/sec theme SSOT #1495.QuickActionThemeSpec({ accent, lozenge? }): consumers define their own specs — agent accents resolved from server config (accentFromIdentityIconon the agent row'sicon_props.color), category pairs defined product-side — and inject them per chip (QuickActionChip.theme) or as a wall default (QuickActionWall theme).getAgentAccentis untouched — it's the pre-existing built-in-agent fallback used byembeddable-chat, outside this wall/chip contract.Consumer impact
The company-hub deck now owns its IT/SEC specs (
CLASSIFICATION_THEMEmaps classification → spec objects directly) — hub PR flamingo-stack/multi-platform-hub#875. Output parity verified in-browser on deck slide 3 (lozenges, accents, marquee all unchanged).🤖 Generated with Claude Code