Skip to content

Delete QUICK_ACTION_THEMES registry — quick-action theme specs are 100% caller-supplied#1496

Merged
michaelassraf merged 1 commit into
mainfrom
refactor/quick-action-theme-caller-specs
Jul 18, 2026
Merged

Delete QUICK_ACTION_THEMES registry — quick-action theme specs are 100% caller-supplied#1496
michaelassraf merged 1 commit into
mainfrom
refactor/quick-action-theme-caller-specs

Conversation

@michaelassraf

Copy link
Copy Markdown
Contributor

Follow-up to #1495 per Michael's review direction: no lib-side theme registry, no fallbacks — all theming is controlled by the caller.

What changed

  • Deleted: QuickActionTheme (the 'fae' | 'mingo' | 'it' | 'sec' union), QUICK_ACTION_THEMES, QuickActionThemeAccents, and the themeAccent/themeAccents override plumbing added in Unify all marquees on one rAF engine: MarqueeWall + QuickActionWall + fae/mingo/it/sec theme SSOT #1495.
  • The contract is now QuickActionThemeSpec ({ accent, lozenge? }): consumers define their own specs — agent accents resolved from server config (accentFromIdentityIcon on the agent row's icon_props.color), category pairs defined product-side — and inject them per chip (QuickActionChip.theme) or as a wall default (QuickActionWall theme).
  • getAgentAccent is untouched — it's the pre-existing built-in-agent fallback used by embeddable-chat, outside this wall/chip contract.
  • Stories updated to define their own demo specs.

Consumer impact

The company-hub deck now owns its IT/SEC specs (CLASSIFICATION_THEME maps classification → spec objects directly) — hub PR flamingo-stack/multi-platform-hub#875. Output parity verified in-browser on deck slide 3 (lozenges, accents, marquee all unchanged).

🤖 Generated with Claude Code

…100% caller-supplied

No lib-side theme names, no fallbacks: QuickActionThemeSpec ({accent, lozenge?}) is now the chip/wall theme contract, injected by the consumer per chip or as a wall default. QuickActionTheme, QUICK_ACTION_THEMES, QuickActionThemeAccents, and the themeAccent/themeAccents plumbing are all deleted. getAgentAccent stays (pre-existing chat contract used by embeddable-chat). Stories define their own demo specs.

Co-Authored-By: Claude Fable 5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@michaelassraf, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 18 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 04e4a922-ecc4-45e2-b2e5-385ba5f66f39

📥 Commits

Reviewing files that changed from the base of the PR and between ad78c5c and 591437d.

📒 Files selected for processing (4)
  • openframe-frontend-core/src/components/chat/chat-quick-action-row.tsx
  • openframe-frontend-core/src/components/chat/quick-action-chip.tsx
  • openframe-frontend-core/src/components/chat/quick-action-wall.tsx
  • openframe-frontend-core/src/stories/QuickActionWall.stories.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/quick-action-theme-caller-specs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@michaelassraf
michaelassraf merged commit 1aca6e5 into main Jul 18, 2026
7 checks passed
@michaelassraf
michaelassraf deleted the refactor/quick-action-theme-caller-specs branch July 18, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant