Skip to content

fix parsing to strip out v if it exists #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kcheung42 merged 1 commit into from
Jun 9, 2026
Merged

fix parsing to strip out v if it exists #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/version_utils/src/version_utils/core.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
Returns nil for nil, blank, or non-numeric input."
[s]
(when (and (string? s) (not (str/blank? s)))
(let [parts (str/split s #"\.")]
(let [parts (-> s (str/replace #"^[vV]" "") (str/split #"\."))]
(when (every? #(re-matches #"\d+" %) parts)
(mapv #?(:clj #(Integer/parseInt %)
:cljs js/parseInt) parts)))))
Expand Down
3 changes: 3 additions & 0 deletions components/version_utils/test/version_utils/test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
(is (= [7 1 4] (vu/parse "7.1.4")))
(is (= [7] (vu/parse "7")))
(is (= [1 0 0] (vu/parse "1.0.0"))))
(testing "strips leading v/V prefix"
(is (= [7 1 5] (vu/parse "v7.1.5")))
(is (= [7 1 4] (vu/parse "V7.1.4"))))
(testing "returns nil for invalid input"
(is (nil? (vu/parse nil)))
(is (nil? (vu/parse "")))
Expand Down
Loading